Skip to content

Fix default Kafka Connetor state#12666

Merged
scholzj merged 1 commit intostrimzi:mainfrom
scholzj:fix-kafka-connector-default-status
Apr 23, 2026
Merged

Fix default Kafka Connetor state#12666
scholzj merged 1 commit intostrimzi:mainfrom
scholzj:fix-kafka-connector-default-status

Conversation

@scholzj
Copy link
Copy Markdown
Member

@scholzj scholzj commented Apr 22, 2026

Type of change

  • Bugfix

Description

Unfortunately, in #12488 I f*cked up the default .spec.state value of the KafkaConnector resource. When a new connector is deployed, everything seems fine. But when you stop it or pause it and then try to unpause/unstop it by deleting the .spec.state field, the connector never transitions back to running state. (when you explicitely set state: running, it works fine)

This PR fixes it by setting the correct default state when .spec.state is unset. It also adds a test to have this situation covered.

This should be considered for cherry-picking for 1.0.0-rc2.

Checklist

  • Write tests
  • Make sure all tests pass
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally

Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj added this to the 1.1.0 milestone Apr 22, 2026
@scholzj scholzj requested a review from katheris April 22, 2026 00:00
@scholzj
Copy link
Copy Markdown
Member Author

scholzj commented Apr 22, 2026

/gha run pipeline=regression

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 22, 2026

⏳ System test verification started: link

The following 6 job(s) will be executed:

  • regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
  • regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
  • regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.07%. Comparing base (33e7553) to head (fdb56e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main   #12666   +/-   ##
=========================================
  Coverage     75.07%   75.07%           
- Complexity     6513     6515    +2     
=========================================
  Files           377      377           
  Lines         25092    25092           
  Branches       3268     3269    +1     
=========================================
  Hits          18838    18838           
  Misses         4914     4914           
  Partials       1340     1340           
Files with missing lines Coverage Δ
...ter/operator/assembly/AbstractConnectOperator.java 87.30% <100.00%> (ø)

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

🎉 System test verification passed: link

Copy link
Copy Markdown
Member

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scholzj LGTM

@scholzj scholzj modified the milestones: 1.1.0, 1.0.0 Apr 23, 2026
@scholzj scholzj merged commit ccc0281 into strimzi:main Apr 23, 2026
32 checks passed
@scholzj scholzj deleted the fix-kafka-connector-default-status branch April 23, 2026 12:39
scholzj added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Jakub Scholz <www@scholzj.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants