Fix default Kafka Connetor state#12666
Merged
scholzj merged 1 commit intostrimzi:mainfrom Apr 23, 2026
Merged
Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
Member
Author
|
/gha run pipeline=regression |
|
⏳ System test verification started: link The following 6 job(s) will be executed:
Tests will start after successful build completion. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12666 +/- ##
=========================================
Coverage 75.07% 75.07%
- Complexity 6513 6515 +2
=========================================
Files 377 377
Lines 25092 25092
Branches 3268 3269 +1
=========================================
Hits 18838 18838
Misses 4914 4914
Partials 1340 1340
🚀 New features to boost your workflow:
|
ppatierno
approved these changes
Apr 22, 2026
|
🎉 System test verification passed: link |
katheris
approved these changes
Apr 23, 2026
scholzj
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Jakub Scholz <www@scholzj.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Unfortunately, in #12488 I f*cked up the default
.spec.statevalue of theKafkaConnectorresource. When a new connector is deployed, everything seems fine. But when you stop it or pause it and then try to unpause/unstop it by deleting the.spec.statefield, the connector never transitions back to running state. (when you explicitely setstate: running, it works fine)This PR fixes it by setting the correct default state when
.spec.stateis unset. It also adds a test to have this situation covered.This should be considered for cherry-picking for 1.0.0-rc2.
Checklist