Skip to content

Fix default Kafka Connetor state #12666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scholzj merged 1 commit into from
Apr 23, 2026
Merged

Fix default Kafka Connetor state #12666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../src/main/java/io/strimzi/operator/cluster/operator/assembly/AbstractConnectOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ private Future<List<Condition>> updateState(Reconciliation reconciliation, Strin
if (!(path instanceof String state)) {
return Future.failedFuture("JSON response lacked $.connector.state");
} else {
ConnectorState targetState = connectorSpec.getState();
ConnectorState targetState = connectorSpec.getState() != null ? connectorSpec.getState() : ConnectorState.RUNNING;
Future<Void> future = Future.succeededFuture();

switch (state) {
Expand Down
93 changes: 93 additions & 0 deletions ...erator/src/test/java/io/strimzi/operator/cluster/operator/assembly/ConnectorMockTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1282,6 +1282,99 @@ public void testConnectorStopResume() {
eq(connectorName));
}

/** Create connect, create connector, stop connector, resume connector by removing the state */
@Test
public void testConnectorStopResumeByUnset() {
String connectName = "cluster";
String connectorName = "connector";

// Create KafkaConnect cluster and wait till it's ready
KafkaConnect connect = new KafkaConnectBuilder()
.withNewMetadata()
.withNamespace(namespace)
.withName(connectName)
.addToAnnotations(Annotations.STRIMZI_IO_USE_CONNECTOR_RESOURCES, "true")
.endMetadata()
.withNewSpec()
.withReplicas(1)
.withBootstrapServers("my-kafka:9092")
.withGroupId("my-group")
.withConfigStorageTopic("my-config-topic")
.withOffsetStorageTopic("my-offset-topic")
.withStatusStorageTopic("my-status-topic")
.endSpec()
.build();
Crds.kafkaConnectOperation(client).inNamespace(namespace).resource(connect).create();
waitForConnectReady(connectName);

// could be triggered twice (creation followed by status update) but waitForConnectReady could be satisfied with single
verify(api, atLeastOnce()).list(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT));
verify(api, never()).createOrUpdatePutRequest(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName), any());

// Create KafkaConnector and wait till it's ready
KafkaConnector connector = new KafkaConnectorBuilder()
.withNewMetadata()
.withName(connectorName)
.withNamespace(namespace)
.addToLabels(Labels.STRIMZI_CLUSTER_LABEL, connectName)
.endMetadata()
.withNewSpec()
.withTasksMax(1)
.withClassName("Dummy")
.endSpec()
.build();
Crds.kafkaConnectorOperation(client).inNamespace(namespace).resource(connector).create();
waitForConnectorReady(connectorName);
waitForConnectorState(connectorName, "RUNNING");

verify(api, times(2)).list(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT));
verify(api, times(1)).createOrUpdatePutRequest(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName), any());
assertThat(connectors.keySet(), is(Collections.singleton(key("cluster-connect-api.testconnectorstopresumebyunset.svc", connectorName))));

verify(api, never()).stop(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));
verify(api, never()).resume(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));

Crds.kafkaConnectorOperation(client).inNamespace(namespace).withName(connectorName).edit(spec -> new KafkaConnectorBuilder(spec)
.editSpec()
.withState(ConnectorState.STOPPED)
.endSpec()
.build());

waitForConnectorState(connectorName, "STOPPED");

verify(api, times(1)).stop(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));
verify(api, never()).resume(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));

Crds.kafkaConnectorOperation(client).inNamespace(namespace).withName(connectorName).edit(sp -> new KafkaConnectorBuilder(sp)
.editSpec()
.withState(null)
.endSpec()
.build());

waitForConnectorState(connectorName, "RUNNING");

verify(api, times(1)).stop(any(),
Comment thread
katheris marked this conversation as resolved.
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));
verify(api, times(1)).resume(any(),
eq(KafkaConnectResources.qualifiedServiceName(connectName, namespace)), eq(KafkaConnectCluster.REST_API_PORT),
eq(connectorName));
}

/** Create connect, create connector, restart connector */
@Test
public void testConnectorRestart() {
Expand Down
Loading