fix: update OCI integration instructions to create custom privilege user and create event rules per instance#4433
Open
felixgateru wants to merge 3 commits intosuperplanehq:mainfrom
Conversation
|
👋 Commands for maintainers:
|
11d7695 to
af0907e
Compare
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit af0907e. Configure here.
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
af0907e to
c2e804c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implements: #4428, #4429
What changed:
The OCI integration's Events rule lifecycle has been redesigned from one rule per trigger to one shared rule per integration+compartment.
The integration setup instructions have also been updated to prompt the user to create a custom user with specified permissions for use in authentication.
Why:
The previous design created a new OCI Events rule every time a trigger was added to a workflow. This caused OCI's per-compartment rule limit to be hit quickly, left orphaned rules behind when triggers were deleted, and duplicated identical rules that all forwarded the same event type to the same ONS topic.
The previous design also had the user use their administrator user API Key credentials which granted SuperPlane administrator capabilities which does not follow best design practices,
How:
Backend:
Frontend:
No frontend changes. The trigger configuration UI and mapper are unaffected.
Notes
New integration instructions:

