refactor(workspace): drop hardcoded core-aspect-env special case#10353
Merged
davidfirst merged 1 commit intorefactor/component-loading-v2-take-2from May 7, 2026
Merged
Conversation
…uildLoadGroups D-001 predicted that the recursive env-DAG sort would make the prepended 'always load core-aspect-env first' workaround unnecessary. Verified: 311-component bit7 workspace (the workspace the special case was written for) loads cleanly without it.
Base automatically changed from
refactor/component-loader-recursive-env-sort
to
refactor/component-loading-v2-take-2
May 7, 2026 19:53
davidfirst
merged commit 6682e50
into
refactor/component-loading-v2-take-2
6 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #10350.
Removes the hardcoded prepend in `buildLoadGroups` that always loaded `teambit.harmony/envs/core-aspect-env` and `teambit.harmony/envs/core-aspect-env-jest` first. With the recursive env-DAG sort from #10350, those envs naturally land in the deepest layer of the topological sort and load early. The hardcode was a workaround for the previous one-level sort.
Verification
Stack