Skip to content

refactor(workspace): drop hardcoded core-aspect-env special case #10353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidfirst merged 1 commit into from
May 7, 2026
+4 −17
Merged

refactor(workspace): drop hardcoded core-aspect-env special case #10353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions scopes/workspace/workspace/workspace-component/workspace-component-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,29 +301,16 @@ export class WorkspaceComponentLoader {
const groupsToHandle = [
// Always load first core envs
{ ids: groupedByIsCoreEnvs.true || [], core: true, aspects: true, seeders: true, envs: true },
// { ids: groupedByIsEnvOfWsComps.true || [], core: false, aspects: true, seeders: false, envs: true },
// The recursive env-DAG sort in `groupEnvsByDepLayer` places envs at the
// bottom of the chain (e.g. `core-aspect-env`/`core-aspect-env-jest`) in the
// earliest layer naturally. The hardcoded `core-aspect-env` prepending that
// used to live here is redundant under the recursive sort — see D-001.
...layeredEnvsGroups,
{ ids: extsNotFromTheList || [], core: false, aspects: true, seeders: false, envs: false },
...layeredExtGroups,
{ ids: groupedByIsExtOfAnother.false || [], core: false, aspects: false, seeders: true, envs: false },
];

// This is a special use case mostly for the bit core repo
const envsOfCoreAspectEnv = ['teambit.harmony/envs/core-aspect-env', 'teambit.harmony/envs/core-aspect-env-jest'];
const coreAspectEnvGroup = { ids: [], core: true, aspects: true, seeders: true, envs: true };
layeredEnvsGroups.forEach((group) => {
const filteredIds = group.ids.filter((id) => envsOfCoreAspectEnv.includes(id.toStringWithoutVersion()));
if (filteredIds.length) {
// @ts-ignore
coreAspectEnvGroup.ids.push(...filteredIds);
}
});
if (coreAspectEnvGroup.ids.length) {
// enter first in the list
groupsToHandle.unshift(coreAspectEnvGroup);
}
// END of bit repo special use case

const groupsByWsScope = groupsToHandle.map((group) => {
if (!group.ids?.length) return undefined;
const groupedByWsScope = groupBy(group.ids, (id) => {
Expand Down