Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the file path candidate list that appears when typing the @ character in AI prompts. It adds two key capabilities: (1) support for including files that are outside the current git repository, and (2) inclusion of the 5 most recently visited buffer files in the candidate list.
Changes:
- Added helper functions to handle out-of-repo files and recent buffer paths
- Refactored
ai-code--visible-window-filesto remove git-repo filtering, enabling out-of-repo file support - Removed three test cases that tested the old implementation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| ai-code-prompt-mode.el | Added ai-code--normalize-path, ai-code--candidate-path, ai-code--current-frame-dired-paths, and ai-code--recent-buffer-paths helper functions; refactored ai-code--visible-window-files to support out-of-repo files; updated ai-code--prompt-filepath-candidates to include recent buffer paths |
| test/test_ai-code-prompt-mode.el | Removed three tests (ai-code-test-visible-window-files, ai-code-test-prompt-filepath-candidates-prioritizes-visible-windows, ai-code-test-prompt-filepath-candidates-includes-dired-directories) that tested the old implementation |
Contributor
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Initial plan * Add tests for refactored helper functions and behaviors Co-authored-by: tninja <714625+tninja@users.noreply.github.com> * Fix trailing whitespace in test Co-authored-by: tninja <714625+tninja@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: tninja <714625+tninja@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
This was referenced Feb 5, 2026
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It added: