Clarify that visible-files contains full absolute paths#157
Closed
Clarify that visible-files contains full absolute paths#157
Conversation
Copilot
AI
changed the title
[WIP] Update candidate filepath list for clarity in response to feedback
Clarify that visible-files contains full absolute paths
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed review question about whether
visible-filescontains full or relative paths in the context of path normalization consistency.Clarification Provided
visible-filesat line 324 contains full absolute paths becauseai-code--visible-window-files()collects files usingbuffer-file-name, which returns absolute paths.This explains why line 325 applies
ai-code--normalize-pathto ensure consistent handling:file-truename(resolves symlinks)expand-file-name(absolute path)The normalized paths are then used in
skip-filesfor comparison at line 299, ensuring the skip logic works correctly regardless of whether files exist.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.