Custom model TOS hyperlink coloring

[dagmfactory]

Issue

The warp terms of service hyperlink on custom inference settings was not readable because of coloring

Before

After

[oz-for-oss]

@dagmfactory

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

Overview

This PR darkens the custom inference Terms of Service hyperlink color in the AI settings tooltip by blending the theme accent with 50% black.

Concerns

• The PR changes user-visible hyperlink styling, but the provided PR description contains no screenshot or screen recording demonstrating the result end to end.

Verdict

Found: 0 critical, 1 important, 0 suggestions

Request changes

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

[oz-for-oss]

⚠️ [IMPORTANT] For this user-facing color change, please include screenshots or a screen recording demonstrating the tooltip link color end to end.

[danielpeng2]

In general we try to avoid going rogue and specifying our own colours for UI in the app. The designs use an accent colour and the rest of our tooltips use an accent colour, so it'd be good to do the same here.

I'd try following the same code we use for font colour in other tooltips, to see if that makes a difference:

warp/crates/warp_core/src/ui/builder.rs

Lines 613 to 620 in bfb4e98

	let font_color: ColorU = self
	.warp_theme
	.accent()
	.on_background(
	Fill::Solid(tooltip_background),
	MinimumAllowedContrast::Text,
	)
	.into();

. In this example, we use an on_background field which should adjust the colour to account for contrast.