Skip to content

Custom model TOS hyperlink coloring #11240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dagmfactory merged 2 commits into from
May 19, 2026
+15 −2
Merged

Custom model TOS hyperlink coloring #11240

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1456692
Custom model TOS hyperlink coloring
dagmfactory May 18, 2026
a0f087a
Use tooltip background
dagmfactory May 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions app/src/settings_view/ai_page.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ use strum::IntoEnumIterator;
use warp_core::channel::ChannelState;
use warp_core::context_flag::ContextFlag;
use warp_core::features::FeatureFlag;
use warp_core::ui::color::contrast::MinimumAllowedContrast;
use warp_core::ui::color::ContrastingColor;
use warp_core::ui::theme::color::internal_colors;
use warp_core::ui::theme::Fill as ThemeFill;
use warpui::elements::{
Border, ChildAnchor, ChildView, ConstrainedBox, CornerRadius, CrossAxisAlignment, Dismiss,
Empty, Expanded, Fill, Hoverable, HyperlinkLens, MainAxisAlignment, MainAxisSize,
Expand Down Expand Up @@ -7091,6 +7094,7 @@ impl ApiKeysWidget {
". BYOK and custom endpoints are intended for individual use and small teams. Companies or organizations with more than 10 employees should use Warp Business or Enterprise.",
),
])]);
let tooltip_background = appearance.theme().tooltip_background();

let info_button =
Hoverable::new(self.custom_inference_info_tooltip.clone(), move |state| {
Expand All @@ -7106,15 +7110,24 @@ impl ApiKeysWidget {
appearance.theme().background().into_solid(),
self.custom_inference_terms_index.clone(),
)
.with_hyperlink_font_color(appearance.theme().accent().into_solid())
.with_hyperlink_font_color(
Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [IMPORTANT] For this user-facing color change, please include screenshots or a screen recording demonstrating the tooltip link color end to end.

appearance
.theme()
.accent()
.on_background(
ThemeFill::Solid(tooltip_background),
MinimumAllowedContrast::Text,
)
.into(),
)
.register_default_click_handlers(|url, ctx, _| {
ctx.dispatch_typed_action(AISettingsPageAction::HyperlinkClick(
url,
));
})
.finish(),
)
.with_background_color(appearance.theme().tooltip_background())
.with_background_color(tooltip_background)
.with_vertical_padding(4.)
.with_horizontal_padding(8.)
.with_border(Border::all(1.).with_border_fill(appearance.theme().outline()))
Expand Down
Loading